Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Remove warning notes from Vault and Consul setup commands. #25153

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Feb 19, 2025

Links

Jira: https://hashicorp.atlassian.net/browse/NET-10260

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad website documentation to reflect this. Refer to
    the website README for docs guidelines. Please also consider whether the
    change requires notes within the upgrade guide.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.

Copy link
Contributor

@pkazmierczak pkazmierczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jrasell jrasell marked this pull request as ready for review February 19, 2025 08:29
@jrasell jrasell requested review from a team as code owners February 19, 2025 08:29
@jrasell jrasell merged commit 32c25d3 into main Feb 19, 2025
33 checks passed
@jrasell jrasell deleted the f-cli-remove-setup-warnings branch February 19, 2025 09:18
@aimeeu aimeeu added the theme/docs Documentation issues and enhancements label Feb 19, 2025
@aimeeu
Copy link
Contributor

aimeeu commented Feb 19, 2025

Added theme/docs and note to myself that this content is for 1.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/docs Documentation issues and enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants