Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fixed formatting and diffs from actual implementation #131

Merged
merged 5 commits into from
Nov 19, 2024

Conversation

hwakabh
Copy link
Contributor

@hwakabh hwakabh commented Nov 19, 2024

Describe the change you are making here!

  • replaced vagrant add with vagrant box add in docs, since there is no subcommands with latest packer
  • fixed markdown styles
  • replaced prefix of box from packer- to output in docs, since it had been modified in implementation

Please include tests. We recommend looking at existing tests as an example.

24-11-19 22:36:17 git/packer-plugin-vagrant [docs/fix-builder-vagrant] % make test
?       github.com/hashicorp/packer-plugin-vagrant      [no test files]
?       github.com/hashicorp/packer-plugin-vagrant/version      [no test files]
ok      github.com/hashicorp/packer-plugin-vagrant/builder/vagrant      1.468s
ok      github.com/hashicorp/packer-plugin-vagrant/post-processor/hcp-vagrant-registry  2.499s
ok      github.com/hashicorp/packer-plugin-vagrant/post-processor/vagrant       2.272s
ok      github.com/hashicorp/packer-plugin-vagrant/post-processor/vagrant-cloud 2.830s

If your PR resolves any open issue(s), please indicate them like this so they will be closed when your PR is merged:
N/A

@hwakabh hwakabh requested a review from a team as a code owner November 19, 2024 13:37
Copy link

hashicorp-cla-app bot commented Nov 19, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hwakabh,

Thanks for the PR, everything looks good to me, we can merge this right now, thanks!

@lbajolet-hashicorp lbajolet-hashicorp merged commit 053b1ca into hashicorp:main Nov 19, 2024
12 checks passed
@hwakabh hwakabh deleted the docs/fix-builder-vagrant branch November 20, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants