packer_test: add SkipNoAcc function

The SkipNoAcc function on PackerTestSuite allows to mark a test run as
not to be run every time we run `make test`, but only when PACKER_ACC=1
is set in the environment.

This allows us to skip executing tests that are either long-running, or
that depend on external dependencies (typically Github), which have a
higher potential to fail on a normal run of Packer tests.

packer_test/core_tests/local_eval_test.go

@@ -5,6 +5,8 @@ import (
 )
 
 func (ts *PackerCoreTestSuite) TestEvalLocalsOrder() {
+	ts.SkipNoAcc()
+
 	pluginDir, cleanup := ts.MakePluginDir()
 	defer cleanup()
 

packer_test/lib/suite.go

@@ -86,6 +86,20 @@ func (ts *PackerTestSuite) BuildSimplePlugin(versionString string, t *testing.T)
 	return outBin
 }
 
+// SkipNoAcc is a pre-condition that skips the test if the PACKER_ACC environment
+// variable is unset, or set to "0".
+//
+// This allows us to build tests with a potential for long runs (or errors like
+// rate-limiting), so we can still test them, but only in a longer timeouted
+// context.
+func (ts *PackerTestSuite) SkipNoAcc() {
+	acc := os.Getenv("PACKER_ACC")
+	if acc == "" || acc == "0" {
+		ts.T().Logf("Skipping test as `PACKER_ACC` is unset.")
+		ts.T().Skip()
+	}
+}
+
 func PackerCoreSuite(t *testing.T) (*PackerTestSuite, func()) {
 	ts := &PackerTestSuite{}
 

packer_test/plugin_tests/init_test.go

@@ -3,6 +3,8 @@ package plugin_tests
 import "github.com/hashicorp/packer/packer_test/lib"
 
 func (ts *PackerPluginTestSuite) TestPackerInitForce() {
+	ts.SkipNoAcc()
+
 	pluginPath, cleanup := ts.MakePluginDir()
 	defer cleanup()
 
@@ -20,6 +22,8 @@ func (ts *PackerPluginTestSuite) TestPackerInitForce() {
 }
 
 func (ts *PackerPluginTestSuite) TestPackerInitUpgrade() {
+	ts.SkipNoAcc()
+
 	pluginPath, cleanup := ts.MakePluginDir()
 	defer cleanup()
 
@@ -64,6 +68,8 @@ func (ts *PackerPluginTestSuite) TestPackerInitWithNonGithubSource() {
 }
 
 func (ts *PackerPluginTestSuite) TestPackerInitWithMixedVersions() {
+	ts.SkipNoAcc()
+
 	pluginPath, cleanup := ts.MakePluginDir()
 	defer cleanup()