-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix documentation url for 'can()' and 'try()' #13022
Fix documentation url for 'can()' and 'try()' #13022
Conversation
I understand this requires an approval. But I am not sure about what to do with "Vercel — Authorization required to deploy." Am I supposed to authorize it? Which I think I have done. Or is it an maintainer that needs to authorize it. Please help. |
Hey @gitbisect, Approved, don't worry about vercel that's for doc previews, it's not a blocker. That being said, may I ask what are you trying to solve? The links are relative to the production environment, and there's a linter that is on the lookout for links like yours. |
Hi @lbajolet-hashicorp I was looking at this because I wanted to see the documentation for The actual destination page is https://github.com/hashicorp/packer/blob/main/website/content/docs/templates/hcl_templates/functions/conversion/try.mdx |
Hi @gitbisect, That is actually expected, the docs we have here are viewable on Github since they're markdown files, but the intent is to upload them to https://developer.hashicorp.com, our documentation website. For example the functions you mention are respectively at: Here, the links render correctly, and I'm not certain we can fix it in one place, and not break it in another, so I believe we should keep the existing links. That being said let me know if you have something else to suggest or questions, but I'd be enclined to close this PR as it's unlikely we can accept this in the current state. |
Perfect. Thanks. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
the urls to can and try files referencing each other are messed up. This PR will fix the URLs