Added support for the FTP protocol. #5849
Conversation
|
Ok, apparently the continuous testing is failng on Go 1.7 because net/url.URL's .Port and .Hostname was introduced in Go 1.8. I'll let you guys know when I get around to writing up the workarounds for older versions of Go. |
|
Ok, I removed the Go 1.8-only usage of .Hostname and .Port and replaced it with an explicit modification to the .Host variable. So it should be fixed and ready for review. |
|
However, it seems that race issue in packer/rpc has triggered in both appveyor and travis-ci's Go 1.8x test? |
… 'non-existent-protocol://'
… ":" looking for the host/port in order to remain backwards-compatible with Go 1.7.
|
Re-based. |
|
Created issue #5902 for this PR. |
|
@arizvisa we're looking at moving to using https://github.com/hashicorp/go-getter for our downloader rather than doing everything in-house. I will probably hold off on reviewing this PR as well as your progress bar one until after that's all figured out (it's in our roadmap for this quarter, so I should be getting to it fairly soon). Just thought I'd let you know I haven't forgotten you, but I'm a little worried this work may be obsolete pretty soon. |
|
ok. it's a pretty minimal change. but whatever you guys feel like doing. i've washed my hands of this pr already. |
|
Okay, fair. |
|
Closing this for now; I don't want to add FTP support and then remove it again once we move to the go-getter library. Sorry. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
This was based on PR #2906, and so was delayed until that got merged upstream.
This is using the ftp client from https://github.com/jlaffaye/ftp as it was the only one I saw at the time that allowed support for resuming and thus could use a goroutine in order to allow interruption/resuming.
Closes issue #478.