Code

Logging and close race in RPC client#661

Code

Open

JHartman5 wants to merge 12 commits intohashicorp:masterhashicorp/serf:masterfrom boxcast:logging-and-close-raceboxcast/serf:logging-and-close-raceCopy head branch name to clipboard

+193-68

Commits

Commits on Aug 8, 2022

• Bugfix: fix 'panic: close of closed channel' by atomically swapping the 'closed' member of RPC client handler structs

  JHartman5

  committed
  22fa478

  Copy full SHA for 22fa478

• Also give the init members the same treatment, and use CompareAndSwap instead of just Swap

  JHartman5

  committed
  7d73b27

  Copy full SHA for 7d73b27

Commits on Aug 17, 2022

• Allow callers to use a custom logger when creating an RPC client

  JHartman5

  committed
  a91ff5d

  Copy full SHA for a91ff5d

• Merge branch 'feat/rpc-client-logger'

  JHartman5

  committed
  20fb2f9

  Copy full SHA for 20fb2f9

• Add mutex protection around 'closed' and response channel closing

  JHartman5

  committed
  2a367e1

  Copy full SHA for 2a367e1

• Merge branch 'bugfix/fix-panic-close-of-closed-channel-in-rpc-client'

  JHartman5

  committed
  c844c95

  Copy full SHA for c844c95

• Fix mutex locking for queryHandler

  JHartman5

  committed
  45ae5c0

  Copy full SHA for 45ae5c0

Commits on Aug 23, 2022

• Add timeouts for Monitor, Stream, and Query requests

  JHartman5

  committed
  d468640

  Copy full SHA for d468640

• Also want to deregister the handler

  JHartman5

  committed
  98a78be

  Copy full SHA for 98a78be

• Use the lower of the client and query parameters timeout for Query

  JHartman5

  committed
  63a526e

  Copy full SHA for 63a526e

• Ok, try something else

  JHartman5

  committed
  7f9fbeb

  Copy full SHA for 7f9fbeb

Commits on Aug 24, 2022

• Minor refactoring for comments and readability

  JHartman5

  committed
  c338aef

  Copy full SHA for c338aef