Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert secretsmanager policy count #305

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Conversation

anniehedgpeth
Copy link
Contributor

@anniehedgpeth anniehedgpeth commented Sep 26, 2023

Background

I had added this change for FDO, but it broke Replicated, so I need to revert it while we do release testing and fix it when I'm back to working on FDO again.

I tested it in this CI run in ptfe-replicated.

@anniehedgpeth anniehedgpeth requested a review from a team as a code owner September 26, 2023 19:57
@anniehedgpeth anniehedgpeth merged commit 600c87d into main Sep 26, 2023
@anniehedgpeth anniehedgpeth deleted the ah/fix-secrets-policy branch September 26, 2023 20:01
@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Sep 26, 2023

/help

Command Description
/test <all|test case name...> [destroy=false] Run the Terraform test workflow on the modules in the tests/ directory. Unnamed arguments can be "all" to run all test cases or specific test case names to only run selected cases. The named argument "destroy=false" will disable the destruction of test infrastructure for debugging purposes.
/destroy <all|test case name...> Destroy any resources that may still be in Terraform state from previous tests. Unnamed arguments can be "all" to destroy all resources from all test cases or specific test case names to only destroy selected test case resources.
/help Shows this help message

Test Case Names

FDO:

  • active-active-rhel7-proxy
  • private-active-active
  • private-tcp-active-active
  • public-active-active
  • standalone-vault

Replicated:

  • active-active-rhel7-proxy-replicated
  • private-active-active-replicated
  • private-tcp-active-active-replicated
  • public-active-active-replicated
  • standalone-vault-replicated

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Sep 26, 2023

/test active-active-rhel7-proxy-replicated destroy=false

❌ Terraform AWS Active/Active RHEL7 Proxy (Replicated) (Legacy) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ❌ Run k6 Smoke Test

❌ Terraform AWS Active/Active RHEL7 Proxy (FDO) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ❌ Run k6 Smoke Test

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Sep 26, 2023

/destroy active-active-rhel7-proxy-replicated

✅ Terraform AWS Active/Active RHEL7 Proxy (FDO) - Destruction Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Destroy

✅ Terraform AWS Active/Active RHEL7 Proxy (Replicated) (Replicated) - Destruction Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Destroy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants