Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a suffix to nested attribute names in generated code #77

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Adding a suffix to nested attribute names in generated code #77

merged 2 commits into from
Oct 24, 2023

Conversation

bendbennett
Copy link
Contributor

Closes: #76

@bendbennett bendbennett requested a review from a team as a code owner October 24, 2023 08:45
@bendbennett bendbennett mentioned this pull request Oct 24, 2023
Closed
bflad
bflad approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

Should we backlog issues for including an edge case specification containing a keyword as an attribute and for ensuring code compiles correctly afterwards?

austinvalle
austinvalle approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bendbennett bendbennett mentioned this pull request Oct 24, 2023
Open
@bendbennett bendbennett merged commit c8ebb0a into main Oct 24, 2023
3 checks passed
@bendbennett bendbennett deleted the bendbennett/issues-76 branch October 24, 2023 14:58
@bendbennett
Copy link
Contributor Author

Should we backlog issues for including an edge case specification containing a keyword as an attribute and for ensuring code compiles correctly afterwards?

#79

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@austinvalle austinvalle austinvalle approved these changes

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure in code generation if nested attribute defines name with reserved Go keyword
3 participants
@bendbennett @bflad @austinvalle