Remove attribute and block schema templates

[bendbennett]

This PR is a follow-up to Consolidate convert and generate packages for datasource, provider, and resource.

The intention is to remove usage of attribute and block schema templates (e.g., bool_attribute.gotmpl, set_nested_block.gotmpl), and to replace with calls to reusable attribute, and block field methods (e.g., ComputedOptionalRequired.Schema()).

Previous implementation of the Schema() method on GeneratorBoolAttribute looked as follows:

func (g GeneratorBoolAttribute) Schema(name generatorschema.FrameworkIdentifier) (string, error) {
	type attribute struct {
		Name                   string
		CustomType             string
		GeneratorBoolAttribute GeneratorBoolAttribute
	}

	a := attribute{
		Name:                   name.ToString(),
		GeneratorBoolAttribute: g,
	}

	switch {
	case g.CustomType != nil:
		a.CustomType = g.CustomType.Type
	case g.AssociatedExternalType != nil:
		a.CustomType = fmt.Sprintf("%sType{}", name.ToPascalCase())
	}

	t, err := template.New("bool_attribute").Parse(boolAttributeTemplate)

	if err != nil {
		return "", err
	}

	if _, err = addAttributeTemplate(t); err != nil {
		return "", err
	}

	var buf strings.Builder

	err = t.Execute(&buf, a)
	if err != nil {
		return "", err
	}

	return buf.String(), nil
}

The Schema() method on GeneratorBoolAttribute now appears as:

func (g GeneratorBoolAttribute) Schema(name generatorschema.FrameworkIdentifier) (string, error) {
	var b bytes.Buffer

	b.WriteString(fmt.Sprintf("%q: schema.BoolAttribute{\n", name))
	b.Write(g.AttributeType.Schema())
	b.Write(g.ComputedOptionalRequired.Schema())
	b.Write(g.Sensitive.Schema())
	b.Write(g.Description.Schema())
	b.Write(g.DeprecationMessage.Schema())
	b.Write(g.ValidatorsCustom.Schema())
	b.WriteString("},")

	return b.String(), nil
}

Further Refactoring

With the changes in this PR, new types (e.g., CustomTypePrimitive) have been added. At this point, the terraform-plugin-codegen-spec CustomType, is held in more than one location within the Generator<Type>Attributes. For example:

type GeneratorBoolAttribute struct {
	AssociatedExternalType   *generatorschema.AssocExtType
	ComputedOptionalRequired convert.ComputedOptionalRequired
	CustomType               *specschema.CustomType
	CustomTypePrimitive      convert.CustomTypePrimitive
	/* ... */     

The CustomType field will be refactored out of GeneratorBoolAttribute as the functions that make use of this field (e.g., Imports(), ModelField()) are refactored to use CustomTypePrimitive.

Equivalent changes will be made for all fields across the various generator types during subsequent refactoring.

[austinvalle]

This all looks good to me, if you want to continue with resource/data source and the other types, I'm good with merging this 🚀

[austinvalle]

Much cleaner and easier to read! I'm a big fan 😄

[austinvalle]

sweet! at a high-level these changes all LGTM. It will be nice to be able to place debug breakpoints in the middle of all this code generation if we need to 😄

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.