Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource Identity: Initial implementation + Schemas #1107

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

austinvalle
Copy link
Member

@austinvalle austinvalle commented Mar 6, 2025

Since Framework has so many files to update, I felt like this was a good breaking point for a first PR. Keeping in draft until we can start running tests with TF core, after which we can start to merge!

This PR implements the tfprotov{5/6}.ProviderServerWithResourceIdentity interface, for each RPC:

  • GetResourceIdentitySchemas: This PR contains about 95% of the implementation with the external packages/internal attribute updates and tests. The missing piece is validation on list attribute (see below).
  • UpgradeResourceIdentity: This RPC will be implemented in a separate PR
  • All of the RPCs that are just adding the identity data to the request/response will be implemented in a separate PR

I will open other PRs based off this to keep a cleaner diff for when we start to merge


Other related PRs for resource identity (coming soon)

  • Adding identity data to request/response of all existing RPCs: #???
  • Validation logic for list attributes: #???
  • Import Resource updates: #???
  • Upgrade Resource Identity implementation: #???
  • Changelogs: #???
  • Website documentation (separate repo): #???

@austinvalle austinvalle added the enhancement New feature or request label Mar 6, 2025
@austinvalle austinvalle added this to the v1.15.0 milestone Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant