-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Data Source: DataZone domain #41480
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @dabcoder 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
% make testacc TESTARGS="-run=TestAccDataZoneDomainDataSource_" PKG=datazone
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/datazone/... -v -count 1 -parallel 20 -run=TestAccDataZoneDomainDataSource_ -timeout 360m -vet=off
2025/03/06 17:03:20 Initializing Terraform AWS Provider...
=== RUN TestAccDataZoneDomainDataSource_basic
=== PAUSE TestAccDataZoneDomainDataSource_basic
=== RUN TestAccDataZoneDomainDataSource_name
=== PAUSE TestAccDataZoneDomainDataSource_name
=== CONT TestAccDataZoneDomainDataSource_basic
=== CONT TestAccDataZoneDomainDataSource_name
--- PASS: TestAccDataZoneDomainDataSource_name (24.68s)
--- PASS: TestAccDataZoneDomainDataSource_basic (24.82s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/datazone 31.631s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@dabcoder thank you for the contribution! 🎉 I added some additional checks to the tests. I also added the ability to query a domain by the |
Warning This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them. Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed. |
Description
Implements a data source for DataZone domains.
Relations
Closes #41426.
References
https://docs.aws.amazon.com/datazone/latest/APIReference/API_ListDomains.html
Output from Acceptance Testing
Would like to get feedback on the acceptance test as I am not sure it's accurate.