Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Source: DataZone domain #41480

Merged
merged 18 commits into from
Mar 7, 2025
Merged

Conversation

dabcoder
Copy link
Contributor

@dabcoder dabcoder commented Feb 20, 2025

Description

Implements a data source for DataZone domains.

Relations

Closes #41426.

References

https://docs.aws.amazon.com/datazone/latest/APIReference/API_ListDomains.html

Output from Acceptance Testing

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/datazone/... -v -count 1 -parallel 20 -run='TestAccDataZoneDomainDataSource_basic'  -timeout 360m -vet=off
2025/02/20 13:41:55 Initializing Terraform AWS Provider...
=== RUN   TestAccDataZoneDomainDataSource_basic
=== PAUSE TestAccDataZoneDomainDataSource_basic
=== CONT  TestAccDataZoneDomainDataSource_basic
--- PASS: TestAccDataZoneDomainDataSource_basic (38.32s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/datazone	43.561s

Would like to get feedback on the acceptance test as I am not sure it's accurate.

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/datazone Issues and PRs that pertain to the datazone service. needs-triage Waiting for first response or review from a maintainer. labels Feb 20, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @dabcoder 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@dabcoder dabcoder marked this pull request as ready for review February 20, 2025 16:44
@dabcoder dabcoder requested a review from a team as a code owner February 20, 2025 16:44
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 20, 2025
johnsonaj
johnsonaj previously approved these changes Mar 6, 2025
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS="-run=TestAccDataZoneDomainDataSource_" PKG=datazone

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/datazone/... -v -count 1 -parallel 20  -run=TestAccDataZoneDomainDataSource_ -timeout 360m -vet=off
2025/03/06 17:03:20 Initializing Terraform AWS Provider...
=== RUN   TestAccDataZoneDomainDataSource_basic
=== PAUSE TestAccDataZoneDomainDataSource_basic
=== RUN   TestAccDataZoneDomainDataSource_name
=== PAUSE TestAccDataZoneDomainDataSource_name
=== CONT  TestAccDataZoneDomainDataSource_basic
=== CONT  TestAccDataZoneDomainDataSource_name
--- PASS: TestAccDataZoneDomainDataSource_name (24.68s)
--- PASS: TestAccDataZoneDomainDataSource_basic (24.82s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/datazone	31.631s

nam054
nam054 previously approved these changes Mar 6, 2025
Copy link
Contributor

@nam054 nam054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

johnsonaj
johnsonaj previously approved these changes Mar 6, 2025
@johnsonaj johnsonaj self-assigned this Mar 6, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 6, 2025
@johnsonaj
Copy link
Contributor

@dabcoder thank you for the contribution! 🎉

I added some additional checks to the tests. I also added the ability to query a domain by the id

@johnsonaj johnsonaj merged commit 3ea172b into hashicorp:main Mar 7, 2025
45 checks passed
Copy link

github-actions bot commented Mar 7, 2025

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.91.0 milestone Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/datazone Issues and PRs that pertain to the datazone service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Data Source]: Data zone domain
4 participants