Changing the tmp directory to the current directory during the length check of terraform-upload #26157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the multiple uploads if the tmp location has less disk space(normally it will be mounted with root) it fails with an error.
Consider if the file size is 20GB and sending it to 10 servers parallelly almost 20*10GB is required to be in /tmp location and if the machine has less tmp size but has sufficient size in another mount the terraform user couldn't send the file to another machine.
As this was a problem was faced by me while uploading a data of 20gb to 100 servers which fails obviously, so changed the code to make sure wherever the user run the terraform, in the same location 'terraform-upload' files will be copied, it removed the factor of using the tmp location.
Reduce the failure if the tmp location has less disk space.