Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the tmp directory to the current directory during the length check of terraform-upload #26157

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ahamedyaserarafath
Copy link

During the multiple uploads if the tmp location has less disk space(normally it will be mounted with root) it fails with an error.
Consider if the file size is 20GB and sending it to 10 servers parallelly almost 20*10GB is required to be in /tmp location and if the machine has less tmp size but has sufficient size in another mount the terraform user couldn't send the file to another machine.

As this was a problem was faced by me while uploading a data of 20gb to 100 servers which fails obviously, so changed the code to make sure wherever the user run the terraform, in the same location 'terraform-upload' files will be copied, it removed the factor of using the tmp location.

Reduce the failure if the tmp location has less disk space.

… check of terraform-upload

Helps to reduce the failure if the tmp location has less disk space.
@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #26157 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted Files Coverage Δ
communicator/ssh/communicator.go 30.78% <0.00%> (-0.23%) ⬇️
terraform/node_resource_plan.go 91.80% <0.00%> (-1.64%) ⬇️
backend/remote/backend_common.go 54.57% <0.00%> (-0.68%) ⬇️
dag/marshal.go 54.44% <0.00%> (+1.11%) ⬆️

Base automatically changed from master to main February 24, 2021 18:01
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants