Add DiagnosticCausedByTestFailure type to be used as Extra in diagnostics cased by a test failure
#36393
+76
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SarahFrench
added
the
no-changelog-needed
…stics raised due to a failing test assertion
…ostics specifically about failed assertions in run blocks
SarahFrench
force-pushed
the
assertion-failure-diag-extra
branch
from
caa6b75 to
328082b
Compare
SarahFrench
removed
the
no-changelog-needed
|
Returned to draft as there was a new test I was going to add |
|
This PR's changes to sensitive value visibility in diagnostics from failing test assertions has been superseded by another PR. The changes in this PR to make test assertion failures easier to identify would need to be adapted to fit with that solution. Closing this PR for reference in future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves how we identify a diagnostic that originates from a failed test assertion.
This PR also changes the output of
terraform testto supply more information about unknown and sensitive values when a test assertion fails. This change is user-facing and is described in the change file.Target Release
1.12.x
CHANGELOG entry