Skip to content
This repository has been archived by the owner on Feb 5, 2024. It is now read-only.

Conversation

piotrromanowski
Copy link

  • Following the PR to add extra_ports parameter to docker plugin,
    this change adds an example of how extra_ports could be used.
    This is a contrived example, but demonstrates the functionality.

- Following the PR to add `extra_ports` parameter to docker plugin,
  this change adds an example of how `extra_ports` could be used.
  This is a contrived example, but demonstrates the functionality.
@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


Piotr Romanowski seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there @piotrromanowski ! Thanks for taking the time to update the waypoint examples repo. I think generally we are trying to keep these platform examples as simple as possible, and so I don't think it makes sense to modify the python example with additional ports to expose. Given the simple nature of the config option, I think this will be covered enough through documentation on the website.

That being said, on your other PR you mentioned that sometimes additional ports could be used for debugging. If you had an example app that demonstrated this, I think that would be a better example of this option as its own project. Let me know what you think!

@piotrromanowski
Copy link
Author

Hey there @piotrromanowski ! Thanks for taking the time to update the waypoint examples repo. I think generally we are trying to keep these platform examples as simple as possible, and so I don't think it makes sense to modify the python example with additional ports to expose. Given the simple nature of the config option, I think this will be covered enough through documentation on the website.

That being said, on your other PR you mentioned that sometimes additional ports could be used for debugging. If you had an example app that demonstrated this, I think that would be a better example of this option as its own project. Let me know what you think!

Ahh that totally makes sense. I can change the PR to add an extra_ports debug example. I can also just drop the PR if it seems unnecessary, nbd 😅

@briancain
Copy link
Member

Ahh that totally makes sense. I can change the PR to add an extra_ports debug example. I can also just drop the PR if it seems unnecessary, nbd

Cool, not a problem! Yeah I'd say close it, and later if you have a good functional example of the debug port, I think it could make for a good example alongside this one! 😄 I could see it going in the features example folder I had mentioned in #58 for showing off more complicated use-cases.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants