Create Hashlist - URGENT #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is really important and affects Web UI and API V2 if wrong key is used.
After some tests, we found that when the payload is being sent with the key separator it works fine and no error is returned and the response returns with the key separator. However, after checking the database no separator is being saved.
{
"0": {
" #_id": 0,
"name": "Test2",
"separator": "",
"useBrain": false,
##.....
}
}
In order for the separator to work this pull request needs to be merged. Maybe some fix in the API v2 @zyronix ? I saw in the PHP at least 3 names for the separator.