-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report multiple lexical errors. Fixes #144 #145
base: master
Are you sure you want to change the base?
Conversation
#if defined(ALEX_BASIC) | ||
alexSetInput (p, x, tail s) | ||
#elif !defined(ALEX_MONAD_BYTESTRING) | ||
alexSetInput (p, x, y, tail s) | ||
#else | ||
alexSetInput (p, x, ByteString.tail s, y) | ||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe @simonmar would prefer another approach for shifting instead of using tail
function. I'd be glad hearing any suggestion ;)
It's not clear to me that this is a good idea in general. We don't know if continuing after an error is a sensible thing to do at all, so it would only be a heuristic, which makes me concerned about adding this behavoiur to the core of Alex. |
Could you explain to me more what do you mean by "sensible thing"? And thanks for the reply. I'd be glad helping in any other good first issue 🙂 |
Take an example like this: |
I have this idea for #144. What do you think, @simonmar ?
A problem I don't know how to solve is that it is only reporting one lexical error per line.