Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP #197: add rules to interpret number literals as character sequences #199

Closed
wants to merge 1 commit into from
Closed

WIP #197: add rules to interpret number literals as character sequences #199

wants to merge 1 commit into from

Conversation

andreasabel
Copy link
Member

@andreasabel andreasabel commented Jan 23, 2022 •
edited
Loading

WIP #197: add rules to interpret number literals as character sequences

I think this fixes the problem, but this isn't the final test case yet, so, WIP.

@andreasabel
Copy link
Member Author

Closed in favor of #200.

@andreasabel
Copy link
Member Author

Actually, I see that #200 breaks #141, so I leave my solution in the race.

@andreasabel andreasabel reopened this Jan 23, 2022
@andreasabel andreasabel mentioned this pull request Jan 23, 2022
Closed
@andreasabel
Copy link
Member Author

There is a problem with regexes like [01-89] which mean one of 0, 1-8, 9. If we already have numbers (NUM), then this is hard to parse. Maybe NUM should only be lexed inside the multiplication brances {nnn,mmm}, using lexer states.

@andreasabel
Copy link
Member Author

Closing in favor of #202.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andreasabel