-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce strict-text and posn-strict-text wrappers and monadUserState-strict-text #240
Conversation
|
b72f69c
to
939b605
Compare
939b605
to
b9c519c
Compare
(As you already noticed)
Adding a dependency like |
@andreasabel It looks like to fully cabalize the test suite is a long term effort, how about I disable the text specific tests on old GHCs? |
e3576b6
to
b1d0de4
Compare
24829c8
to
ee9cff3
Compare
Yes, that seems fair, especially since you add a new feature so it is less important to test it with old GHCs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this new feature!
I have some small change requests concerning the documentation.
Unfortunately, the docs are not built automatically from the PR even though I switched it on now at readthedocs.org
. Probably it only works on new PRs...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose we merge this, try it out a bit, and then release.
Ok to squash?
If you want to preserve separate commits, please reorganize them so that there are no fixups and each commit has a clear purpose and commit message.
Otherwise, we squash them into one big PR commit.
Cool! Squash is fine. |
I now tested this PR locally by porting one of my projects to the new |
A new major version (3.4.0.0) looks more appropriate for a new feature, one can then have |
This PR introduces the strict-text and posn-strict-text wrappers to allows working with Data.Text out of the box.
Implementation wise we could do a bit better by using Data.Text.Foreign.takeWord8 and avoiding the intermediate list of bytes in a codepoint but this will do for now.