Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace undefined with more descriptive error #262

Merged
merged 4 commits into from
Dec 30, 2024
Merged

Replace undefined with more descriptive error #262

merged 4 commits into from
Dec 30, 2024

Conversation

brandonchinn178
Copy link
Contributor

If this error is thrown, it's difficult to debug: https://gitlab.haskell.org/ghc/ghc/-/issues/25609

andreasabel
andreasabel reviewed Dec 29, 2024
View reviewed changes
Copy link
Member

@andreasabel andreasabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Would it be possible to add a reproducer?

@brandonchinn178
Copy link
Contributor Author

@andreasabel How's that?

@andreasabel
Copy link
Member

andreasabel commented Dec 30, 2024 •
edited
Loading

Thanks!

Somehow the testsuite fails:
https://github.com/haskell/alex/actions/runs/12545028715/job/34978736577#step:9:97

make: *** No rule to make target 'issue_262.n.run', needed by 'tests'.

@andreasabel
Copy link
Member

Hopefully adding the missing issue_262.x to the extra-source-files fixes this...

@andreasabel andreasabel added this to the 3.5.2.0 milestone Dec 30, 2024
@andreasabel andreasabel added the error reporting Concerning errors thrown by alex label Dec 30, 2024
@andreasabel andreasabel self-assigned this Dec 30, 2024
@andreasabel
Copy link
Member

https://github.com/haskell/alex/actions/runs/12548981514/job/34989207762?pr=262#step:9:111

issue_262.x:21:11: error:
Illegal type signature: ‘SomeException’
Type signatures are only allowed in patterns with ScopedTypeVariables

@andreasabel andreasabel merged commit 261aa08 into haskell:master Dec 30, 2024
20 checks passed
@andreasabel
Copy link
Member

Released as 3.5.2.0.

@brandonchinn178 brandonchinn178 deleted the patch-1 branch December 30, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreasabel andreasabel andreasabel left review comments

Assignees

@andreasabel andreasabel

Labels
error reporting Concerning errors thrown by alex
Projects
None yet
Milestone
3.5.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@brandonchinn178 @andreasabel