Remove useless INLINE on compareLength for lazy bytestrings.
#705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function is self-recursive so will never inline. I also don't see the benefit of the INLINE pragma in the first place. Fixes haskell#704.
|
At a glance CI failures seem unrelated to the actual change. |
Bodigrim
approved these changes
Mar 3, 2025
clyring
approved these changes
Mar 4, 2025
The FreeBSD failure is some new metadata bitrot, certainly unrelated indeed. I'm not sure what's going on with the s390x job. For now I'm hoping it just goes away on its own. |
|
The error message in the s390x job on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function is self-recursive so will never inline. I also don't see the benefit of the INLINE pragma in the first place.
Fixes #704.