Merge pull request #10616 from geekosaur/openbsd-overstrip

OpenBSD `--strip-unneeded` strips too much
haskell · Dec 8, 2024 · 2851fe1 · 2851fe1
2 parents e6a20a3 + cd4bd1f
commit 2851fe1
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/Cabal/src/Distribution/Simple/Program/Strip.hs b/Cabal/src/Distribution/Simple/Program/Strip.hs
@@ -58,6 +58,10 @@ stripLib verbosity (Platform arch os) progdb path = do
     IOS -> return ()
     AIX -> return ()
     Solaris -> return ()
+    OpenBSD ->
+      -- '--strip-unneeded' sometimes strips too much on OpenBSD.
+      -- -- See https://cvsweb.openbsd.org/cgi-bin/cvsweb/~checkout~/ports/lang/ghc/patches/patch-libraries_Cabal_Cabal_Distribution_Simple_Program_Strip_hs
+      return ()
     Windows ->
       -- Stripping triggers a bug in 'strip.exe' for
       -- libraries with lots identically named modules. See

diff --git a/changelog.d/pr-10616 b/changelog.d/pr-10616
@@ -0,0 +1,11 @@
+---
+synopsis: "OpenBSD `--strip-unneeded` sometimes strips too much"
+packages: [Cabal]
+prs: 10616
+---
+
+OpenBSD's `--strip-unneeded` thinks some symbols are unneeded that are in fact
+needed when C bits are involved, so suppress its use.
+
+Taken from the OpenBSD ports repo (https://cvsweb.openbsd.org/cgi-bin/cvsweb/~checkout~/ports/lang/ghc/patches/patch-libraries_Cabal_Cabal_Distribution_Simple_Program_Strip_hs);
+brought to our attention by maerwald.