hpc: Don't cover non-dependency libraries #10250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alt-romes
force-pushed
the
wip/romes/10046
branch
3 times, most recently
from
bbef74e to
ab7b5e8
Compare
jasagredo
reviewed
Aug 7, 2024
| @@ -1,4 +1,5 @@ | |||
| {-# LANGUAGE DeriveFunctor, DeriveFoldable, DeriveTraversable #-} | |||
| {-# OPTIONS_GHC -ddump-to-file -ddump-simpl -ddump-stg-final #-} | |||
There was a problem hiding this comment.
This looks like a leftover?
|
Good to see progress on this regression, thanks!
I think it does modify behavior, because cabal will crash less after the patch. Remember, template B is mostly just for documentation, tests, CI. |
alt-romes
force-pushed
the
wip/romes/10046
branch
2 times, most recently
from
812be41 to
b8c16c7
Compare
Fine, updated and pushed a changelog. |
jasagredo
approved these changes
Aug 8, 2024
ulysses4ever
approved these changes
Aug 8, 2024
alt-romes
added
merge me
20 tasks
mergify
bot
added
the
merge delay passed
Mikolaj
force-pushed
the
wip/romes/10046
branch
from
b8c16c7 to
d4ef453
Compare
|
@mergify rebase |
❌ Unable to rebase: user
|
We were passing the flag --coverage-for for every library in the package when building the testsuites. However, if a particular testsuite doesn't depend on one of the packages passed with --coverage-for we would crash. Since we look for the unit ids of all packages given in --coverage-for in the package database (to find hpc artifacts), if the testsuite builds before the library this lookup would fail. The fix is easy: don't pass --coverage-for=<lib> to <testsuite> if <testsuite> doesn't depend on <lib>. If <lib> is an indirect dependency of <testsuite> it'll no longer be covered by HPC, but this is a weird behaviour that I doubt anyone relies on. Fixes haskell#10046
alt-romes
force-pushed
the
wip/romes/10046
branch
from
d4ef453 to
c3b8cee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were passing the flag --coverage-for for every library in the package when building the testsuites.
However, if a particular testsuite doesn't depend on one of the packages passed with --coverage-for we would crash.
Since we look for the unit ids of all packages given in --coverage-for in the package database (to find hpc artifacts), if the testsuite builds before the library this lookup would fail.
The fix is easy: don't pass --coverage-for= to if doesn't depend on . If is an indirect dependency of it'll no longer be covered by HPC, but this is a weird behaviour that I doubt anyone relies on.
Fixes #10046
Please read Github PR Conventions and then fill in one of these two templates.
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR: