Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master: make Cabal-hooks version track Cabal version #10580

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sheaf
Copy link
Collaborator

@sheaf sheaf commented Nov 22, 2024

This PR targets the Cabal master branch.

As pointed out in #10412, it isn't currently feasible to version the Cabal-hooks version separately from Cabal due to the large amount of re-exports (in particular the LocalBuildInfo type and its dependencies).

For the time being, we version Cabal-hooks along with the major Cabal library version.

Companion to #10579.

As pointed out in haskell#10412, it isn't currently feasible to version the
Cabal-hooks version separately from Cabal due to the large amount of
re-exports (in particular the LocalBuildInfo type and its dependencies).

For the time being, we will version Cabal-hooks along with the major
Cabal library version.
@sheaf sheaf changed the title Make Cabal-hooks version track Cabal version Master: make Cabal-hooks version track Cabal version Nov 22, 2024
Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Any plans for a Hackage release?

Cabal-hooks/changelog.md Outdated Show resolved Hide resolved
@sheaf sheaf added merge me Tell Mergify Bot to merge squash+merge me Tell Mergify Bot to squash-merge and removed attention: needs-review merge me Tell Mergify Bot to merge labels Dec 6, 2024
@mergify mergify bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days labels Dec 6, 2024
Copy link
Contributor

mergify bot commented Dec 8, 2024

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days ready and waiting Mergify is waiting out the cooldown period squash+merge me Tell Mergify Bot to squash-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants