Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create changelogs for 3.14.1.0 #10591

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

Kleidukos
Copy link
Member

Forward-port of #10576

Copy link
Collaborator

@geekosaur geekosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit ("which" is fine informally but I think changelogs should be a little more formal).

release-notes/Cabal-3.14.1.0.md Show resolved Hide resolved
@Mikolaj
Copy link
Member

Mikolaj commented Nov 23, 2024

This is still borked: #10576 (comment)

@Kleidukos Kleidukos force-pushed the changelogs-for-3.14.1.0-master branch from 83cda6b to 906d26f Compare November 23, 2024 22:23
@Kleidukos
Copy link
Member Author

@Mikolaj I've integrated your suggestion, please review

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two typos I've described are gone on this branch (what about 3.14 branch?). Thank you for including the 3.14.0.0 changelogs. If they were included in a separate section, it would be easy to tell what changed between 3.14.0.0 and 3.14.1.0, but it's probably a rare use case and the way it's set up makes it easier to read for a person that switches from 3.12.* to 3.14.1.0 directly, which is the common case, so I don't object. I haven't proof-read everything carefully, so another pair of eyes would be welcome. Maybe @ffaf1 finds a moment?

release-notes/Cabal-3.14.1.0.md Show resolved Hide resolved
release-notes/Cabal-3.14.1.0.md Show resolved Hide resolved
@Kleidukos Kleidukos added squash+merge me Tell Mergify Bot to squash-merge merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days labels Nov 27, 2024
@mergify mergify bot added the ready and waiting Mergify is waiting out the cooldown period label Nov 27, 2024
@mergify mergify bot merged commit 33cee3d into haskell:master Nov 27, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days ready and waiting Mergify is waiting out the cooldown period squash+merge me Tell Mergify Bot to squash-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants