-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create changelogs for 3.14.1.0 #10591
Create changelogs for 3.14.1.0 #10591
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit ("which" is fine informally but I think changelogs should be a little more formal).
This is still borked: #10576 (comment) |
83cda6b
to
906d26f
Compare
@Mikolaj I've integrated your suggestion, please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The two typos I've described are gone on this branch (what about 3.14 branch?). Thank you for including the 3.14.0.0 changelogs. If they were included in a separate section, it would be easy to tell what changed between 3.14.0.0 and 3.14.1.0, but it's probably a rare use case and the way it's set up makes it easier to read for a person that switches from 3.12.* to 3.14.1.0 directly, which is the common case, so I don't object. I haven't proof-read everything carefully, so another pair of eyes would be welcome. Maybe @ffaf1 finds a moment?
Forward-port of #10576