Fix sdist #256
Fix sdist #256
Conversation
| happy_boot = bootstrap_root </> "happy" | ||
| callProcess "cabal" | ||
| [ "install", "happy", | ||
| "-f", "-bootstrap", |
There was a problem hiding this comment.
| "-f", "-bootstrap", | |
| "-f", "+bootstrap", |
Don't we want that?
There was a problem hiding this comment.
That would require a pre-installed happy
There was a problem hiding this comment.
With -f -bootstrap we don't, with -f +bootstrap we do. That's how this flag works, and I think you named it 😄
There was a problem hiding this comment.
Sorry! I wasn't loading your comments, I meant to reply to myself not rudely reply to you! 😳 😬
There was a problem hiding this comment.
Yes, this is not the first time my own name for the flag has confused me 😅
There was a problem hiding this comment.
I think this also confuses me.
I would think that -f +bootstrap would do something so that this instance of happy can build itself, whereas a -f -bootstrap would require another (already installed) instance of happy.
Or in other words, flag on does something special, flag off does the vanilla thing.
|
@int-index wrote:
These instructions shouldn't just reside in a closed PR, they need to go into Also the |
Fixes #255
The new release process is:
runhaskell ./bootstrap.hs. This replaces.yand.lyfiles with.hsfiles, which applies to:packages/frontend/src/Happy/Frontend/Parser/Bootstrapped.lypackages/frontend/src/Happy/Frontend/AttrGrammar/Parser.lycabal v2-sdist allThis results in the following tarballs:
Thanks to the
./bootstrap.hsstep, thehappy-frontend-2.0.tar.gztarball contains*.hsfiles instead ofBootstrapped.lyandParser.ly. This should fix the issues that the users of1.21.0encountered.The bump to
2.0is motivated by the split into packages. I believe it's a major change that enables the use ofhappyas a library, so it deserves a major version bump. It does not indicate a breaking change.