Support GHC as the only compiler to build happy generated parsers #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgraf812
reviewed
Jun 16, 2024
Kariiem
force-pushed
the
ghc-compiler-only
branch
from
a9793e7 to
014ddd6
Compare
Kariiem
force-pushed
the
ghc-compiler-only
branch
from
014ddd6 to
3d5a060
Compare
sgraf812
reviewed
Jun 21, 2024
There was a problem hiding this comment.
I think it would be feasible now to give type signatures to the main functions, such as happyDoAction, happyShift and happyGoto. In my experience, being able to write these down would have helped me quite a bit while developing the resumptive draft.
Otherwise this looks good to me.
sgraf812
reviewed
Jun 21, 2024
sgraf812
reviewed
Jun 22, 2024
Kariiem
force-pushed
the
ghc-compiler-only
branch
from
f434f2b to
21f25f8
Compare
Kariiem
force-pushed
the
ghc-compiler-only
branch
from
21f25f8 to
6c3719d
Compare
Applying a few suggestions on the PR
sgraf812
force-pushed
the
ghc-compiler-only
branch
from
cad4aab to
1457766
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all the code related
-g/--ghcargs, making it on by default, removing all conditional code based on it, so that the generated parsers can only build with GHC compiler.@int-index @Ericson2314 @sgraf812 This PR is has another commit, from #276, ignore it for now, I based the second commit on it just to make merging both easier, rather than doing rebase/merge later.