Attribute grammar cleanup #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only some backends support it
Ericson2314
force-pushed
the
attribute-cleanup
branch
from
9ebd2f4 to
e81500f
Compare
Merged
|
Anyone want to review? |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to better separate the attribute grammar stuff
Much code doesn't care at all (rightly or wrongly), so we can use the types to track which does does.
Only one backend supports it, it should be ill-typed to try to use it with the other backend. (This is not yet achieved, but step in that directly.
Generally trying to slim down
Grammarto just the essentials, the grammar itself.