-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to ghc 9.10 #480
base: main
Are you sure you want to change the base?
Upgrade to ghc 9.10 #480
Conversation
Status update: this is functionally complete, but waiting for ghc 9.10 to become available in stackage snapshot so I can upgrade stack ci config |
Hello @jaspervdj |
Thanks! |
I am addressing the broken CI here: #484 IMO we should not switch the stack CI over to use the newest GHC version (yet), as long as it's covered by cabal we're good. This avoids the chicken-and-egg problem. |
Sounds great. Feel free to merge your PR and I'll rebase this PR on top, removing CI changes from this one. |
@@ -9,13 +9,13 @@ jobs: | |||
strategy: | |||
matrix: | |||
os: [ubuntu-latest, macOS-latest] | |||
ghc: ["9.4", "9.6", "9.8"] | |||
ghc: ["9.6", "9.8", "9.10"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI removing 9.4 from CI, because its associated base 4.17 is out of bounds for ghc-lib-parser, which requires base >= 4.18.
Can we make progress on this now? |
db87892
to
aa9f155
Compare
@michaelpj The current state is that ~10/278 tests are still failing with ghc 9.10. |
Trying to make things work with GHC 9.10, for the purpose of including stylish-haskell in haskell language server (haskell/haskell-language-server#4233)