Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ghc 9.10 #480

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Upgrade to ghc 9.10 #480

wants to merge 5 commits into from

Conversation

jhrcek
Copy link

@jhrcek jhrcek commented May 29, 2024

Trying to make things work with GHC 9.10, for the purpose of including stylish-haskell in haskell language server (haskell/haskell-language-server#4233)

@jhrcek
Copy link
Author

jhrcek commented Jun 23, 2024

Status update: this is functionally complete, but waiting for ghc 9.10 to become available in stackage snapshot so I can upgrade stack ci config

@jhrcek jhrcek marked this pull request as ready for review June 28, 2024 04:38
@jhrcek
Copy link
Author

jhrcek commented Jun 28, 2024

Hello @jaspervdj
could you please check this PR?
The only thing missing I think is updating stack CI config to use ghc 9.10 based resolver.
But in in stackage I see stylish-haskell has been disabled because it doesn't support ghc 9.10 (see commercialhaskell/stackage#7414), so it seems like a bit of a chicken-egg problem.
Would it make sense to you to 1) disable stack ci temporarily and then 2) release new version of stylish-haskell with 9.10 support to hackage so we could enable it with ghc 9.10 in hls?

@jaspervdj
Copy link
Member

Thanks!

@jaspervdj
Copy link
Member

I am addressing the broken CI here: #484

IMO we should not switch the stack CI over to use the newest GHC version (yet), as long as it's covered by cabal we're good. This avoids the chicken-and-egg problem.

@jhrcek
Copy link
Author

jhrcek commented Jun 30, 2024

Sounds great. Feel free to merge your PR and I'll rebase this PR on top, removing CI changes from this one.

@@ -9,13 +9,13 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macOS-latest]
ghc: ["9.4", "9.6", "9.8"]
ghc: ["9.6", "9.8", "9.10"]
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI removing 9.4 from CI, because its associated base 4.17 is out of bounds for ghc-lib-parser, which requires base >= 4.18.

@michaelpj
Copy link
Contributor

Can we make progress on this now?

@jhrcek
Copy link
Author

jhrcek commented Oct 2, 2024

@michaelpj The current state is that ~10/278 tests are still failing with ghc 9.10.
I remembered we were trying to fix them with Alan Z during zurihac but we gave up, because Alan realized something fundamental is missing in EP annotations within ghc said he'd try to get this fixed for the next 9.10 patch release.

@danwdart danwdart mentioned this pull request Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants