First draft of a ChronicleT.CPS #174
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phadej
reviewed
Apr 9, 2022
| {-# INLINE chronicle #-} | ||
|
|
||
| runChronicle :: Monoid c => Chronicle c a -> These c a | ||
| runChronicle = runIdentity . flip runChronicleT mempty |
There was a problem hiding this comment.
I was afraid there is something like that, i.e. Monoid pops in, instead of Semigroup.
Just guessing, would ChronicleT { runChronicleT :: Maybe c -> m (These c a) } work better (and still do the job?)
phadej
reviewed
Apr 9, 2022
| t <- runChronicleT m c | ||
| case t of | ||
| This c' -> return (This c') | ||
| That a -> runChronicleT (k a) c |
There was a problem hiding this comment.
this branch would have Nothing. It looks suspicious as is.
|
don't worry about failures with older GHCs. I'll fix them up (or just drop support, pre-AMP GHCs are quite old). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first draft of the ChronicleT CPS proposal in #173. However, there seems to be an inherent flaw in CPS-ifying
ChronicleTakin toWriterT.CPS, in thatchronicleneeds to turnThatintoThesein order to pass on the accumulated output. Alsopureandreturnnow generate aThesevalue instead ofThat.I'm open to any suggestions.