-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add service account template to graphql-engine
#19
Conversation
Just some tests with
|
charts/graphql-engine/values.yaml
Outdated
@@ -96,6 +96,8 @@ healthChecks: | |||
serviceAccount: | |||
enabled: false | |||
name: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we just set graphql-engine
directly to this name
field. Users won't need to explore the helm source template to know the default service account name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That works! I wasn't sure if there was a preference!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hgiasac was that a request or suggestion? Shall I push that as a change?
LGTM. Thanks for contributing |
Adds a service account template for the
graphql-engine
chart. This template will be rendered (default name:graphql-engine
) whenserviceAccount.enabled
is set totrue
, also allows adding desiredannotations
orlabels
to the service account.Fixes #18