Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade v2.43 and remove disableAnnotationTimestamp #26

Merged
merged 1 commit into from
Sep 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/graphql-data-connector/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ type: application

# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.6.0
version: 0.7.0

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 2.41.0
appVersion: 2.43.0
6 changes: 3 additions & 3 deletions charts/graphql-data-connector/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ This chart deploys the GraphQL Data Connector service.

1. Helm (preferably v3) installed – instructions are [here](https://helm.sh/docs/intro/install/).
2. Hasura helm repo configured.

```bash
helm repo add hasura https://hasura.github.io/helm-charts
helm repo update
Expand All @@ -19,11 +19,12 @@ helm repo update
```bash
helm install [RELEASE_NAME] hasura/graphql-data-connector
```

See [configuration](#parameters) below.

See [helm install](https://helm.sh/docs/helm/helm_install/) for command documentation.

## Parameters
## Parameters

| Name | Description | Value |
| ------------------------------------------------- | ---------------------------------------------------------------------------------------------------------- | ------------------------------- |
Expand All @@ -32,7 +33,6 @@ See [helm install](https://helm.sh/docs/helm/helm_install/) for command document
| `global.prefixOverride` | Override the naming prefix instead of the release name | `{{ .Release.Name }}` |
| `nameOverride` | String to override the deployment name | `""` |
| `namespaceOverride` | String to override the namespace | `""` |
| `disableAnnotationTimestamp` | Disable the current timestamp annotation that force the pod to roll out | `true` |
| `labels` | Add labels to the deployment resource | `{}` |
| `annotations` | Add annotations to the deployment resource | `{}` |
| `command` | Customize the execution command | `[]` |
Expand Down
3 changes: 0 additions & 3 deletions charts/graphql-data-connector/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@ spec:
template:
metadata:
annotations:
{{- if not .Values.disableAnnotationTimestamp }}
deployment-timestamp: "{{ date "20060102150405" now }}"
{{- end }}
{{- if .Values.annotations }}
{{- toYaml .Values.annotations | nindent 8 }}
{{- end }}
Expand Down
4 changes: 2 additions & 2 deletions charts/graphql-engine/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@ type: application

# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.6.0
version: 0.7.0

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 2.41.0
appVersion: 2.43.0

dependencies:
- name: postgres
Expand Down
11 changes: 5 additions & 6 deletions charts/graphql-engine/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ This chart deploys the GraphQL Engine service with a Postgres instance for metad
1. Kubernetes 1.16+
2. Helm (preferably v3) installed – instructions are [here](https://helm.sh/docs/intro/install/).
3. Hasura helm repo configured.

```bash
helm repo add hasura https://hasura.github.io/helm-charts
helm repo update
Expand All @@ -22,13 +22,14 @@ helm repo update
```bash
helm install [RELEASE_NAME] hasura/graphql-engine
```

See [configuration](#parameters) below.

See [helm install](https://helm.sh/docs/helm/helm_install/) for command documentation.

### Configuration Examples

See configuration examples [here](./examples).
See configuration examples [here](./examples).

### Uninstall Helm Chart

Expand All @@ -40,7 +41,7 @@ This removes all the Kubernetes components associated with the chart and deletes

See [helm uninstall](https://helm.sh/docs/helm/helm_uninstall/) for command documentation.

## Parameters
## Parameters

### Global parameters

Expand All @@ -56,7 +57,6 @@ See [helm uninstall](https://helm.sh/docs/helm/helm_uninstall/) for command docu
| ------------------------------------------------- | --------------------------------------------------------------------------------------------------------- | ----------------------- |
| `nameOverride` | String to override the deployment name | `""` |
| `namespaceOverride` | String to override the namespace | `""` |
| `disableAnnotationTimestamp` | Disable the current timestamp annotation that force the pod to roll out | `true` |
| `labels` | Add labels to the deployment resource | `{}` |
| `annotations` | Add annotations to the deployment resource | `{}` |
| `command` | Customize the execution command | `[]` |
Expand Down Expand Up @@ -154,7 +154,7 @@ See [helm uninstall](https://helm.sh/docs/helm/helm_uninstall/) for command docu

### Postgres parameters

See the [PostgreSQL helm chart](../postgres) for full list of parameters.
See the [PostgreSQL helm chart](../postgres) for full list of parameters.

| Name | Description | Value |
| ------------------ | -------------------------------- | ------ |
Expand All @@ -167,4 +167,3 @@ See the [PostgreSQL helm chart](../postgres) for full list of parameters.
| `podMonitor.enabled` | Enable the Prometheus PodMonitor resource. Require [Prometheus Operator](https://github.com/prometheus-operator/prometheus-operator) to be installed | `false` |
| `podMonitor.interval` | The monitor scrape interval | `15s` |
| `podMonitor.scrapeTimeout` | The monitor scrape timeout | `10s` |

2 changes: 1 addition & 1 deletion charts/graphql-engine/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
{{- end }}

{{- define "common.secretsName" -}}
{{- $secretName := coalesce (.Values.secret).name (.Values.secrets).name -}}
{{- $secretName := (.Values.secret).name -}}
{{- if $secretName -}}
{{- print $secretName }}
{{- else -}}
Expand Down
2 changes: 1 addition & 1 deletion charts/graphql-engine/templates/secrets.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# This file and its contents are licensed under the Apache License 2.0.
# Please see the included NOTICE for copyright information and LICENSE for a copy of the license.

{{- with coalesce .Values.secret .Values.secrets }}
{{- with .Values.secret }}
{{- if or .enabled ($.Values.postgres).enabled }}
{{ $hgeRedisUrl := tpl .redisUrl $ }}
{{ $hgeRateLimitRedisUrl := tpl .rateLimitRedisUrl $ }}
Expand Down
10 changes: 5 additions & 5 deletions charts/hasura-enterprise-stack/Chart.lock
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
dependencies:
- name: graphql-engine
repository: file://../graphql-engine
version: 0.6.0
version: 0.7.0
- name: graphql-data-connector
repository: file://../graphql-data-connector
version: 0.6.0
version: 0.7.0
- name: mongo-data-connector
repository: file://../mongo-data-connector
version: 0.6.0
version: 0.7.0
- name: redis
repository: oci://registry-1.docker.io/bitnamicharts
version: 17.15.2
Expand All @@ -20,5 +20,5 @@ dependencies:
- name: jaeger
repository: https://jaegertracing.github.io/helm-charts
version: 0.71.18
digest: sha256:4b8ee7c2ce67c32fa5baee383b03f8547e81b74f1c82994a133605082ca7a84a
generated: "2024-07-30T23:56:40.079366979+07:00"
digest: sha256:cb356632fadad8122729fa36547f0dd87a554cf75197cedbb636cc7ec260d126
generated: "2024-09-30T23:37:04.099500562+07:00"
10 changes: 5 additions & 5 deletions charts/hasura-enterprise-stack/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,23 +17,23 @@ type: application

# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.6.0
version: 0.7.0

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 2.41.0
appVersion: 2.43.0

dependencies:
- name: graphql-engine
version: 0.6.0
version: 0.7.0
repository: file://../graphql-engine
condition: graphql-engine.enabled
- name: graphql-data-connector
version: 0.6.0
version: 0.7.0
repository: file://../graphql-data-connector
condition: global.connector.graphql.enabled
- name: mongo-data-connector
version: 0.6.0
version: 0.7.0
repository: file://../mongo-data-connector
condition: global.connector.mongo.enabled
- name: redis
Expand Down
4 changes: 2 additions & 2 deletions charts/mongo-data-connector/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ type: application

# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.6.0
version: 0.7.0

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 2.41.0
appVersion: 2.43.0
6 changes: 3 additions & 3 deletions charts/mongo-data-connector/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ This chart deploys the GraphQL Data Connector service.

1. Helm (preferably v3) installed – instructions are [here](https://helm.sh/docs/intro/install/).
2. Hasura helm repo configured.

```bash
helm repo add hasura https://hasura.github.io/helm-charts
helm repo update
Expand All @@ -19,11 +19,12 @@ helm repo update
```bash
helm install [RELEASE_NAME] hasura/mongo-data-connector
```

See [configuration](#parameters) below.

See [helm install](https://helm.sh/docs/helm/helm_install/) for command documentation.

## Parameters
## Parameters

| Name | Description | Value |
| ------------------------------------------------- | ----------------------------------------------------------------------------------------------- | ----------------------------- |
Expand All @@ -32,7 +33,6 @@ See [helm install](https://helm.sh/docs/helm/helm_install/) for command document
| `global.prefixOverride` | Override the naming prefix instead of the release name | `{{ .Release.Name }}` |
| `nameOverride` | String to override the deployment name | `""` |
| `namespaceOverride` | String to override the namespace | `""` |
| `disableAnnotationTimestamp` | Disable the current timestamp annotation that force the pod to roll out | `true` |
| `labels` | Add labels to the deployment resource | `{}` |
| `annotations` | Add annotations to the deployment resource | `{}` |
| `command` | Customize the execution command | `[]` |
Expand Down
3 changes: 0 additions & 3 deletions charts/mongo-data-connector/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@ spec:
template:
metadata:
annotations:
{{- if not .Values.disableAnnotationTimestamp }}
deployment-timestamp: "{{ date "20060102150405" now }}"
{{- end }}
{{- if .Values.annotations }}
{{- toYaml .Values.annotations | nindent 8 }}
{{- end }}
Expand Down
4 changes: 0 additions & 4 deletions charts/mongo-data-connector/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,6 @@ serviceAccount:
##
annotations: {}

## Disable the deploy timestamp annotation to skip force rollout
##
disableAnnotationTimestamp: true

## The deployment strategy to use to replace existing pods with new ones.
## DeploymentStrategy describes how to replace existing pods with new ones.
strategy: {}
Expand Down
Loading