Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-platform docker image build #42

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Conversation

daniel-chambers
Copy link
Collaborator

This PR updates the CI build so that the connector's base docker image build is built for both amd64 and arm64. This should help it run more efficiently on Apple Silicon machines which use ARM chips.

@daniel-chambers daniel-chambers self-assigned this Aug 26, 2024
@daniel-chambers daniel-chambers changed the title Add multiarch docker image build Add multi-platform docker image build Aug 26, 2024
Copy link

@sordina sordina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this tested in CI?

@daniel-chambers
Copy link
Collaborator Author

Yes, you can see it working in the CI build output: https://github.com/hasura/ndc-nodejs-lambda/actions/runs/10553982043/job/29235127676?pr=42

@daniel-chambers daniel-chambers merged commit e8c1f8e into main Aug 26, 2024
4 checks passed
@daniel-chambers daniel-chambers deleted the daniel/multiarch-docker branch August 26, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants