Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ES version and ignored TS compiler diagnostics that Deno ignores #77

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

daniel-chambers
Copy link
Contributor

This PR ignores TypeScript diagnostic error codes that Deno itself ignores. It also fixes the target compilation language which got broken in #63's merge. Fatal errors occurring on a particular file are prefixed with FATAL too.

Copy link
Contributor

@sordina sordina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stacks of hacks! Definitely agree that we should rework the approach when we get some breathing room. Should be a good fix for now.

@sordina sordina merged commit aef295c into main Nov 24, 2023
1 check passed
@daniel-chambers daniel-chambers deleted the daniel/ignore-denos-diagnostics branch November 24, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants