Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Fastify dependency version #92

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Pin Fastify dependency version #92

merged 2 commits into from
Jan 30, 2024

Conversation

daniel-chambers
Copy link
Contributor

@daniel-chambers daniel-chambers commented Jan 30, 2024

This PR pins the version of Fastify used to ensure that we avoid using the latest version which is not compatible with Deno because it uses AsyncResource.emitDestroy.

Fastify incompatible changes:
image

Changelog

  • Add a changelog entry (in the "Changelog entry" section below) if the changes in this PR have any user-facing impact.
  • If no changelog is required ignore/remove this section and add a no-changelog-required label to the PR.

Type

(Select only one. In case of multiple, choose the most appropriate)

  • highlight
  • enhancement
  • bugfix
  • behaviour-change
  • performance-enhancement
  • security-fix

Changelog entry

Pinned the Fastify version used to avoid using the latest version which does not work with Deno

@daniel-chambers daniel-chambers merged commit 1ecaa5a into main Jan 30, 2024
1 check passed
@daniel-chambers daniel-chambers deleted the daniel/pin-fastify branch January 30, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants