Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: order DAG steps before inserting #1268

Merged
merged 1 commit into from
Feb 13, 2025
Merged

fix: order DAG steps before inserting #1268

merged 1 commit into from
Feb 13, 2025

Conversation

abelanger5
Copy link
Contributor

Description

Fixes reported issues when DAG steps are inserted out of order, referencing parents which have been defined after the child. This PR orders steps in a topological ordering before insertion.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@abelanger5 abelanger5 requested a review from grutt February 13, 2025 14:49
Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hatchet-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 2:50pm

@grutt grutt merged commit 9d1c40a into main Feb 13, 2025
30 checks passed
@grutt grutt deleted the belanger/dag-ordering branch February 13, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants