test(timeout): add test for timeout #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
abelanger5
requested changes
Apr 10, 2024
examples/timeout/main_e2e_test.go
Outdated
| Description: "timeout", | ||
| Steps: []*worker.WorkflowStep{ | ||
| worker.Fn(func(ctx worker.HatchetContext) (result *stepOneOutput, err error) { | ||
| time.Sleep(time.Second * 60) |
There was a problem hiding this comment.
I think it'd be better if we made sure the timeout signal propagates to the step over ctx.Done(), rather than just sleeping
There was a problem hiding this comment.
Good point, I thought we already tested this in the cancellation but indeed it's not quite the same thing. I'll adapt.
abelanger5
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
Type of change
What's Changed