Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rp2040 correct dcd_edpt_iso_activate #2937

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pschatzmann
Copy link
Contributor

Describe the PR
I think your last redesign of my iso implementation has introduced an error. The audio is not wokring any more.
This PR resolves the issue.

Additional context
See these comments
#2838

@HiFiPhile
Copy link
Collaborator

Thank you for the fix, I did a forced push to fix the CI.

It seems strange to add hw_endpoint_init() in dcd_edpt_iso_activate()since it has already been called indcd_edpt_iso_alloc()`, beside packet size is there anything changed between these calls ?

@pschatzmann
Copy link
Contributor Author

I did not double check this: I just added it back because it was also there before the change and removing it was breaking it from working properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants