Partial typehints for bleak/__init__.py #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siecje
force-pushed
the
typehints_1
branch
3 times, most recently
from
557e092
to
28e06b4
Compare
dlech
reviewed
Feb 14, 2024
bleak/__init__.py
Outdated
| @@ -154,11 +155,16 @@ def __init__( | |||
| **kwargs, | |||
| ) | |||
|
|
|||
| async def __aenter__(self): | |||
| async def __aenter__(self) -> "BleakScanner": | |||
There was a problem hiding this comment.
We should be able to drop the quotes since we have from __future__ import annotations in this file already.
bleak/__init__.py
Outdated
Comment on lines
529
to
536
| disconnected_callback=( | ||
| None | ||
| if disconnected_callback is None | ||
| else functools.partial(disconnected_callback, self) | ||
| ), | ||
| services=( | ||
| None if services is None else set(map(normalize_uuid_str, services)) | ||
| ), |
There was a problem hiding this comment.
This looks unrelated. I'm guessing black did this?
dlech
reviewed
Feb 14, 2024
bleak/__init__.py
Outdated
| return f"<{self.__class__.__name__}, {self.address}, {type(self._backend)}>" | ||
|
|
||
| # Async Context managers | ||
|
|
||
| async def __aenter__(self): | ||
| async def __aenter__(self) -> "BleakClient": |
There was a problem hiding this comment.
Can remove the quotes here too.
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.