Merge pull request #33 from hbmartin/update-detekt-and-gradle

Upgrade detekt to 1.23.7

README.md

@@ -14,7 +14,7 @@ These are my opinions. There are many like them but these are mine. 😄
 
 Inside of your `dependencies` block add the following: (for more details see [adding more rule sets](https://github.com/detekt/detekt#adding-more-rule-sets))
 ```kotlin 
-detektPlugins("me.haroldmartin:hbmartin-detekt-rules:0.1.6")
+detektPlugins("me.haroldmartin:hbmartin-detekt-rules:0.1.7")
 ```
 
 Then add to your detekt configuration as in the section below to activate rules. Note that the AvoidFirstOrLastOnList and AvoidMutableCollections rules require [type resolution](https://detekt.dev/docs/gettingstarted/type-resolution) to be active.

build.gradle.kts

@@ -9,7 +9,7 @@ plugins {
 }
 
 group = "me.haroldmartin.detektrules"
-version = "0.1.6"
+version = "0.1.7"
 
 dependencies {
     compileOnly(libs.detekt.api)

gradle/libs.versions.toml

@@ -1,5 +1,5 @@
 [versions]
-detekt = "1.23.6"
+detekt = "1.23.7"
 
 [libraries]
 detekt-api = { group = "io.gitlab.arturbosch.detekt", name = "detekt-api", version.ref = "detekt" }

gradle/wrapper/gradle-wrapper.properties

@@ -1,6 +1,6 @@
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-8.10-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-8.10.1-bin.zip
 networkTimeout=10000
 validateDistributionUrl=true
 zipStoreBase=GRADLE_USER_HOME

gradlew

@@ -15,6 +15,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
+# SPDX-License-Identifier: Apache-2.0
+#
 
 ##############################################################################
 #
@@ -55,7 +57,7 @@
 #       Darwin, MinGW, and NonStop.
 #
 #   (3) This script is generated from the Groovy template
-#       https://github.com/gradle/gradle/blob/HEAD/subprojects/plugins/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt
+#       https://github.com/gradle/gradle/blob/HEAD/platforms/jvm/plugins-application/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt
 #       within the Gradle project.
 #
 #       You can find Gradle at https://github.com/gradle/gradle/.
@@ -84,7 +86,8 @@ done
 # shellcheck disable=SC2034
 APP_BASE_NAME=${0##*/}
 # Discard cd standard output in case $CDPATH is set (https://github.com/gradle/gradle/issues/25036)
-APP_HOME=$( cd "${APP_HOME:-./}" > /dev/null && pwd -P ) || exit
+APP_HOME=$( cd -P "${APP_HOME:-./}" > /dev/null && printf '%s
+' "$PWD" ) || exit
 
 # Use the maximum available, or set MAX_FD != -1 to use that value.
 MAX_FD=maximum

gradlew.bat

@@ -13,6 +13,8 @@
 @rem See the License for the specific language governing permissions and
 @rem limitations under the License.
 @rem
+@rem SPDX-License-Identifier: Apache-2.0
+@rem
 
 @if "%DEBUG%"=="" @echo off
 @rem ##########################################################################

src/main/kotlin/me/haroldmartin/detektrules/NoCallbacksInFunctions.kt

@@ -45,12 +45,13 @@ class NoCallbacksInFunctions(config: Config) : Rule(config) {
                 }
             }
             ?.takeIf { it.isNotEmpty() }
-            ?.let {
+            ?.let { callbacks ->
                 report(
                     CodeSmell(
                         issue = issue,
                         entity = Entity.from(function),
-                        message = "${function.name ?: "Function"} should not have callbacks: ${it.joinToString()}",
+                        message = "${function.name ?: "Function"} should not have callbacks: " +
+                            callbacks.joinToString(),
                     ),
                 )
             }