Skip to content

Commit

Permalink
Fix tests and related faults in tag files #7
Browse files Browse the repository at this point in the history
  • Loading branch information
@TobiasNx
TobiasNx committed Sep 10, 2024
1 parent a4b4bb8 commit 7a6eb2e
Show file tree
Hide file tree
Showing 36 changed files with 40 additions and 40 deletions.
2 changes: 1 addition & 1 deletion src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/Tag940.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static Tag940 getInstance() {
private void initialize() {
tag = "940";
label = "reserviert für BVB";
mqTag = "reserviert für BVB";
mqTag = "ReserviertFürBVB";
cardinality = Cardinality.Repeatable;
descriptionUrl = "https://service-wiki.hbz-nrw.de/pages/viewpage.action?pageId=698777686";

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/Tag941.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static Tag941 getInstance() {
private void initialize() {
tag = "941";
label = "reserviert für BVB";
mqTag = "reserviert für BVB";
mqTag = "ReserviertFürBVB";
cardinality = Cardinality.Repeatable;
descriptionUrl = "https://service-wiki.hbz-nrw.de/pages/viewpage.action?pageId=698777686";

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/Tag942.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static Tag942 getInstance() {
private void initialize() {
tag = "942";
label = "reserviert für BVB";
mqTag = "reserviert für BVB";
mqTag = "ReserviertFürBVB";
cardinality = Cardinality.Repeatable;
descriptionUrl = "https://service-wiki.hbz-nrw.de/pages/viewpage.action?pageId=698777686";

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/Tag943.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static Tag943 getInstance() {
private void initialize() {
tag = "943";
label = "reserviert für BVB";
mqTag = "reserviert für BVB";
mqTag = "ReserviertFürBVB";
cardinality = Cardinality.Repeatable;
descriptionUrl = "https://service-wiki.hbz-nrw.de/pages/viewpage.action?pageId=698777686";

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/Tag944.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static Tag944 getInstance() {
private void initialize() {
tag = "944";
label = "reserviert für BVB";
mqTag = "reserviert für BVB";
mqTag = "ReserviertFürBVB";
cardinality = Cardinality.Repeatable;
descriptionUrl = "https://service-wiki.hbz-nrw.de/pages/viewpage.action?pageId=698777686";

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/Tag945.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static Tag945 getInstance() {
private void initialize() {
tag = "945";
label = "reserviert für EKZ";
mqTag = "reserviert für EKZ";
mqTag = "ReserviertFürEKZ";
cardinality = Cardinality.Repeatable;
descriptionUrl = "https://service-wiki.hbz-nrw.de/pages/viewpage.action?pageId=698777686";

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/Tag946.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static Tag946 getInstance() {
private void initialize() {
tag = "946";
label = "reserviert für EKZ";
mqTag = "reserviert für EKZ";
mqTag = "ReserviertFürEKZ";
cardinality = Cardinality.Repeatable;
descriptionUrl = "https://service-wiki.hbz-nrw.de/pages/viewpage.action?pageId=698777686";

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/Tag947.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static Tag947 getInstance() {
private void initialize() {
tag = "947";
label = "reserviert für EKZ";
mqTag = "reserviert für EKZ";
mqTag = "ReserviertFürEKZ";
cardinality = Cardinality.Repeatable;
descriptionUrl = "https://service-wiki.hbz-nrw.de/pages/viewpage.action?pageId=698777686";

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/Tag948.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static Tag948 getInstance() {
private void initialize() {
tag = "948";
label = "reserviert für EKZ";
mqTag = "reserviert für EKZ";
mqTag = "ReserviertFürEKZ";
cardinality = Cardinality.Repeatable;
descriptionUrl = "https://service-wiki.hbz-nrw.de/pages/viewpage.action?pageId=698777686";

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/Tag949.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static Tag949 getInstance() {
private void initialize() {
tag = "949";
label = "reserviert für EKZ";
mqTag = "reserviert für EKZ";
mqTag = "ReserviertFürEKZ";
cardinality = Cardinality.Repeatable;
descriptionUrl = "https://service-wiki.hbz-nrw.de/pages/viewpage.action?pageId=698777686";

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/Tag950.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static Tag950 getInstance() {
private void initialize() {
tag = "950";
label = "reserviert für GBV";
mqTag = "reserviert für GBV";
mqTag = "ReserviertFürGBV";
cardinality = Cardinality.Repeatable;
descriptionUrl = "https://service-wiki.hbz-nrw.de/pages/viewpage.action?pageId=698777686";

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/Tag951.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static Tag951 getInstance() {
private void initialize() {
tag = "951";
label = "reserviert für GBV";
mqTag = "reserviert für GBV";
mqTag = "ReserviertFürGBV";
cardinality = Cardinality.Repeatable;
descriptionUrl = "https://service-wiki.hbz-nrw.de/pages/viewpage.action?pageId=698777686";

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/Tag952.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static Tag952 getInstance() {
private void initialize() {
tag = "952";
label = "reserviert für GBV";
mqTag = "reserviert für GBV";
mqTag = "ReserviertFürGBV";
cardinality = Cardinality.Repeatable;
descriptionUrl = "https://service-wiki.hbz-nrw.de/pages/viewpage.action?pageId=698777686";

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/Tag953.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static Tag953 getInstance() {
private void initialize() {
tag = "953";
label = "reserviert für GBV";
mqTag = "reserviert für GBV";
mqTag = "ReserviertFürGBV";
cardinality = Cardinality.Repeatable;
descriptionUrl = "https://service-wiki.hbz-nrw.de/pages/viewpage.action?pageId=698777686";

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/Tag954.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static Tag954 getInstance() {
private void initialize() {
tag = "954";
label = "reserviert für GBV";
mqTag = "reserviert für GBV";
mqTag = "ReserviertFürGBV";
cardinality = Cardinality.Repeatable;
descriptionUrl = "https://service-wiki.hbz-nrw.de/pages/viewpage.action?pageId=698777686";

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/Tag955.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static Tag955 getInstance() {
private void initialize() {
tag = "955";
label = "reserviert für HeBIS";
mqTag = "reserviert für HeBIS";
mqTag = "ReserviertFürHeBIS";
cardinality = Cardinality.Repeatable;
descriptionUrl = "https://service-wiki.hbz-nrw.de/pages/viewpage.action?pageId=698777686";

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/Tag956.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static Tag956 getInstance() {
private void initialize() {
tag = "956";
label = "reserviert für HeBIS";
mqTag = "reserviert für HeBIS";
mqTag = "ReserviertFürHeBIS";
cardinality = Cardinality.Repeatable;
descriptionUrl = "https://service-wiki.hbz-nrw.de/pages/viewpage.action?pageId=698777686";

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/Tag957.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static Tag957 getInstance() {
private void initialize() {
tag = "957";
label = "reserviert für HeBIS";
mqTag = "reserviert für HeBIS";
mqTag = "ReserviertFürHeBIS";
cardinality = Cardinality.Repeatable;
descriptionUrl = "https://service-wiki.hbz-nrw.de/pages/viewpage.action?pageId=698777686";

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/Tag958.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static Tag958 getInstance() {
private void initialize() {
tag = "958";
label = "reserviert für HeBIS";
mqTag = "reserviert für HeBIS";
mqTag = "ReserviertFürHeBIS";
cardinality = Cardinality.Repeatable;
descriptionUrl = "https://service-wiki.hbz-nrw.de/pages/viewpage.action?pageId=698777686";

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/Tag959.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static Tag959 getInstance() {
private void initialize() {
tag = "959";
label = "reserviert für HeBIS";
mqTag = "reserviert für HeBIS";
mqTag = "ReserviertFürHeBIS";
cardinality = Cardinality.Repeatable;
descriptionUrl = "https://service-wiki.hbz-nrw.de/pages/viewpage.action?pageId=698777686";

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/Tag966.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static Tag966 getInstance() {
private void initialize() {
tag = "966";
label = "reserviert für KOBV";
mqTag = "reserviert für KOBV";
mqTag = "ReserviertFürKOBV";
cardinality = Cardinality.Repeatable;
descriptionUrl = "https://service-wiki.hbz-nrw.de/pages/viewpage.action?pageId=698777686";

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/Tag967.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static Tag967 getInstance() {
private void initialize() {
tag = "967";
label = "reserviert für KOBV";
mqTag = "reserviert für KOBV";
mqTag = "ReserviertFürKOBV";
cardinality = Cardinality.Repeatable;
descriptionUrl = "https://service-wiki.hbz-nrw.de/pages/viewpage.action?pageId=698777686";

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/Tag968.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static Tag968 getInstance() {
private void initialize() {
tag = "968";
label = "reserviert für KOBV";
mqTag = "reserviert für KOBV";
mqTag = "ReserviertFürKOBV";
cardinality = Cardinality.Repeatable;
descriptionUrl = "https://service-wiki.hbz-nrw.de/pages/viewpage.action?pageId=698777686";

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/Tag969.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static Tag969 getInstance() {
private void initialize() {
tag = "969";
label = "reserviert für KOBV";
mqTag = "reserviert für KOBV";
mqTag = "ReserviertFürKOBV";
cardinality = Cardinality.Repeatable;
descriptionUrl = "https://service-wiki.hbz-nrw.de/pages/viewpage.action?pageId=698777686";

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/Tag970.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static Tag970 getInstance() {
private void initialize() {
tag = "970";
label = "reserviert für OBV";
mqTag = "reserviert für OBV";
mqTag = "ReserviertFürOBV";
cardinality = Cardinality.Repeatable;
descriptionUrl = "https://service-wiki.hbz-nrw.de/pages/viewpage.action?pageId=698777686";

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/Tag971.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static Tag971 getInstance() {
private void initialize() {
tag = "971";
label = "reserviert für OBV";
mqTag = "reserviert für OBV";
mqTag = "ReserviertFürOBV";
cardinality = Cardinality.Repeatable;
descriptionUrl = "https://service-wiki.hbz-nrw.de/pages/viewpage.action?pageId=698777686";

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/Tag972.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static Tag972 getInstance() {
private void initialize() {
tag = "972";
label = "reserviert für OBV";
mqTag = "reserviert für OBV";
mqTag = "ReserviertFürOBV";
cardinality = Cardinality.Repeatable;
descriptionUrl = "https://service-wiki.hbz-nrw.de/pages/viewpage.action?pageId=698777686";

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/Tag973.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static Tag973 getInstance() {
private void initialize() {
tag = "973";
label = "reserviert für OBV";
mqTag = "reserviert für OBV";
mqTag = "ReserviertFürOBV";
cardinality = Cardinality.Repeatable;
descriptionUrl = "https://service-wiki.hbz-nrw.de/pages/viewpage.action?pageId=698777686";

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/Tag974.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static Tag974 getInstance() {
private void initialize() {
tag = "974";
label = "reserviert für OBV";
mqTag = "reserviert für OBV";
mqTag = "ReserviertFürOBV";
cardinality = Cardinality.Repeatable;
descriptionUrl = "https://service-wiki.hbz-nrw.de/pages/viewpage.action?pageId=698777686";

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/Tag975.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static Tag975 getInstance() {
private void initialize() {
tag = "975";
label = "reserviert für NB Schweiz und Schweiz";
mqTag = "reserviert für NB Schweiz und Schweiz";
mqTag = "ReserviertFürNB Schweiz und Schweiz";
cardinality = Cardinality.Repeatable;
descriptionUrl = "https://service-wiki.hbz-nrw.de/pages/viewpage.action?pageId=698777686";

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/Tag976.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static Tag976 getInstance() {
private void initialize() {
tag = "976";
label = "reserviert für NB Schweiz und Schweiz";
mqTag = "reserviert für NB Schweiz und Schweiz";
mqTag = "ReserviertFürNB Schweiz und Schweiz";
cardinality = Cardinality.Repeatable;
descriptionUrl = "https://service-wiki.hbz-nrw.de/pages/viewpage.action?pageId=698777686";

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/Tag977.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static Tag977 getInstance() {
private void initialize() {
tag = "977";
label = "reserviert für NB Schweiz und Schweiz";
mqTag = "reserviert für NB Schweiz und Schweiz";
mqTag = "ReserviertFürNB Schweiz und Schweiz";
cardinality = Cardinality.Repeatable;
descriptionUrl = "https://service-wiki.hbz-nrw.de/pages/viewpage.action?pageId=698777686";

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/Tag978.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static Tag978 getInstance() {
private void initialize() {
tag = "978";
label = "reserviert für NB Schweiz und Schweiz";
mqTag = "reserviert für NB Schweiz und Schweiz";
mqTag = "ReserviertFürNB Schweiz und Schweiz";
cardinality = Cardinality.Repeatable;
descriptionUrl = "https://service-wiki.hbz-nrw.de/pages/viewpage.action?pageId=698777686";

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/Tag979.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static Tag979 getInstance() {
private void initialize() {
tag = "979";
label = "reserviert für NB Schweiz und Schweiz";
mqTag = "reserviert für NB Schweiz und Schweiz";
mqTag = "ReserviertFürNB Schweiz und Schweiz";
cardinality = Cardinality.Repeatable;
descriptionUrl = "https://service-wiki.hbz-nrw.de/pages/viewpage.action?pageId=698777686";

Expand Down
6 changes: 3 additions & 3 deletions src/test/java/de/gwdg/metadataqa/marc/utils/DataElementsStaticticsTest.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ public void testStatistics() {
assertEquals( 229, statistics.get(DataElementType.coreFields));
assertEquals( 184, statistics.get(DataElementType.coreIndicators));
assertEquals(2667, statistics.get(DataElementType.coreSubfields));
assertEquals( 300, statistics.get(DataElementType.localFields));
assertEquals( 337, statistics.get(DataElementType.localFields));
assertEquals( 64, statistics.get(DataElementType.localIndicators));
assertEquals(2489, statistics.get(DataElementType.localSubfields));
assertEquals(6151, statistics.total());
assertEquals(2571, statistics.get(DataElementType.localSubfields));
assertEquals(6270, statistics.total());
}
}
6 changes: 3 additions & 3 deletions src/test/java/de/gwdg/metadataqa/marc/utils/MarcTagListerTest.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public void testListTag() {
List<Class<? extends DataFieldDefinition>> tags = MarcTagLister.listTags();
assertNotNull(tags);
assertNotEquals(0, tags.size());
assertEquals(529, tags.size());
assertEquals(566, tags.size());
assertEquals("Tag010", tags.get(0).getSimpleName());
Map<String, Integer> versionCounter = new HashMap<>();
Map<MarcVersion, Integer> versionCounter2 = new HashMap<>();
Expand Down Expand Up @@ -118,8 +118,8 @@ public void testListTag() {
assertEquals( 12, (int) versionCounter2.get(MarcVersion.OGYK));
assertEquals( 12, (int) versionCounter.get("ogyktags"));

assertEquals( 72, (int) versionCounter2.get(MarcVersion.HBZ));
assertEquals( 72, (int) versionCounter.get("hbztags"));
assertEquals( 109, (int) versionCounter2.get(MarcVersion.HBZ));
assertEquals( 109, (int) versionCounter.get("hbztags"));

assertEquals(229, (int) versionCounter2.get(MarcVersion.MARC21));
assertEquals( 2, (int) versionCounter.get("holdings"));
Expand Down

0 comments on commit 7a6eb2e

Please sign in to comment.