Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete wrong mappings #107 #108

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Delete wrong mappings #107 #108

wants to merge 1 commit into from

Conversation

TobiasNx
Copy link
Contributor

@TobiasNx TobiasNx commented Dec 11, 2024

Resolves #107

Had a quick look at the mapping. There were four records that were obviously not matching the mapping to NZ records but to local ones also the mappings of these four seem to be completly wrong.

Therefore I suggest deleting them.

Copy link
Contributor

@acka47 acka47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@fsteeg
Copy link
Member

fsteeg commented Dec 12, 2024

Is this file used for anything? Isn't it superseded by the one in lookup-tables?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete faulty almaMmsId mappings that are refering to local records
3 participants