Draft moving the hbzId for Articles to containedIn RPB-232 #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mechanism works but the examples are no good since the articles/images have the hbzId of the article and not the parent publication that would be https://lobid.org/resources/990029283680206441#! or http://lobid.org/resources/990187208710206441#!
TobiasNx
force-pushed
the
RPB-232-containedInWithHbzId
branch
from
2261c52 to
df6478e
Compare
TobiasNx
commented
Dec 11, 2024
| @@ -3,7 +3,6 @@ | |||
| "type" : [ "BibliographicResource", "Article" ], | |||
| "rpbId" : "929t112201", | |||
| "id" : "https://lobid.org/resources/929t112201", | |||
| "hbzId" : "CT003010543", | |||
There was a problem hiding this comment.
This seems to be the real hbzId of the resource not the one of the parent publication.
TobiasNx
commented
Dec 11, 2024
Comment on lines
+76
to
+78
| "containedIn" : [ { | ||
| "id" : "https://lobid.org/resources/CT003010543#!" | ||
| } ], |
There was a problem hiding this comment.
This then would introduce an error.
TobiasNx
commented
Dec 11, 2024
| @@ -3,7 +3,6 @@ | |||
| "type" : [ "BibliographicResource", "Article" ], | |||
| "rpbId" : "929t112202", | |||
| "id" : "https://lobid.org/resources/929t112202", | |||
| "hbzId" : "CT003010542", | |||
There was a problem hiding this comment.
This seems to be the real hbzId of the resource not the one of the parent publication.
TobiasNx
commented
Dec 11, 2024
Comment on lines
+76
to
+78
| "containedIn" : [ { | ||
| "id" : "https://lobid.org/resources/CT003010542#!" | ||
| } ], |
There was a problem hiding this comment.
This then would introduce an error.
TobiasNx
commented
Dec 11, 2024
| @@ -3,7 +3,6 @@ | |||
| "type" : [ "BibliographicResource", "Article" ], | |||
| "rpbId" : "929t112200", | |||
| "id" : "https://lobid.org/resources/929t112200", | |||
| "hbzId" : "CT003010348", | |||
There was a problem hiding this comment.
This seems to be the real hbzId of the resource not the one of the parent publication.
TobiasNx
commented
Dec 11, 2024
Comment on lines
+76
to
+78
| "containedIn" : [ { | ||
| "id" : "https://lobid.org/resources/CT003010348#!" | ||
| } ], |
There was a problem hiding this comment.
This then would introduce an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunatly I have no test for this in the test strapi data. @fsteeg could you add an test from strapi e.g. https://rpb.lbz-rlp.de/929t172921?format=json
The existing examples are no good perhaps hinting to a inconsistency in applying the hbzId of the parent publication to articles and not their own.
e.g.
https://rpb.lbz-rlp.de/929t112200 (Palatinatus Rheni [Elektronische Ressource] : [Ca. 1:1 900 000])
has:
linked to https://lobid.org/resources/990187209140206441#! (Palatinatus Rheni )
But source would be: Bertius, Petrus : P. Bertii Tabularum geographicarum contractarum libri septem
Does it make sense to introduce a new property in strapi? Parent publication or something? So that we can assigne both the hbzId of the resource AND the hbzId of the harbouring parent resource?