Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor housekeeping updates #1246

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from
Open

Minor housekeeping updates #1246

wants to merge 14 commits into from

Conversation

rly
Copy link
Contributor

@rly rly commented Feb 8, 2025

Motivation

  • Update ruff action to non-deprecated one
  • Update github-app-token action to official github one
  • Remove requirements-min.txt in favor of an optional dependency group in pyproject.toml and update docs accordingly
  • Update pyproject.toml license key to correct format
  • Add back ruff mccabe complexity check which was accidentally removed in transition to ruff
  • Clean up ruff config

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 85.50725% with 10 lines in your changes missing coverage. Please review.

Project coverage is 90.95%. Comparing base (b8a1a26) to head (722a772).

Files with missing lines Patch % Lines
src/hdmf/spec/spec.py 66.66% 4 Missing and 3 partials ⚠️
src/hdmf/common/resources.py 90.32% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1246      +/-   ##
==========================================
+ Coverage   90.87%   90.95%   +0.08%     
==========================================
  Files          42       42              
  Lines        9537     9535       -2     
  Branches     1926     1918       -8     
==========================================
+ Hits         8667     8673       +6     
+ Misses        576      570       -6     
+ Partials      294      292       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly enabled auto-merge (squash) February 8, 2025 08:33
@rly rly requested a review from mavaylon1 February 8, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant