Skip to content

Commit

Permalink
Remove --dev from tests that have own settings
Browse files Browse the repository at this point in the history
Many of these tests were passing --dev to test runs that should
be running our JIT or using indy. This effectively prevented
those jobs from actually using the JIT. This is likely an
mistake made when combining similar jobs to simplify the workflow.
  • Loading branch information
headius committed Mar 2, 2023
1 parent 5d7d15f commit 3ef5653
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
- name: bundle install
run: bin/jruby --dev -S bundle install
- name: rake ${{ matrix.target }}
run: bin/jruby --dev -S rake ${{ matrix.target }}
run: bin/jruby -S rake ${{ matrix.target }}

rake-test-8:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -81,7 +81,7 @@ jobs:
- name: bundle install
run: bin/jruby --dev -S bundle install
- name: rake ${{ matrix.target }}
run: bin/jruby --dev -S rake ${{ matrix.target }}
run: bin/jruby -S rake ${{ matrix.target }}

jruby-tests-dev:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -156,7 +156,7 @@ jobs:
- name: bundle install
run: bin/jruby --dev -S bundle install
- name: rake ${{ matrix.target }}
run: bin/jruby --dev -S rake ${{ matrix.target }}
run: bin/jruby -S rake ${{ matrix.target }}

mvn-test:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -266,7 +266,7 @@ jobs:
- name: bundle install
run: bin/jruby --dev -S bundle install
- name: rake spec:ji
run: bin/jruby --dev -S rake spec:ji
run: bin/jruby -S rake spec:ji

regression-specs-jit:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -301,7 +301,7 @@ jobs:
- name: bundle install
run: bin/jruby --dev -S bundle install
- name: rake spec:regression
run: bin/jruby --dev -S rake spec:regression
run: bin/jruby -S rake spec:regression

mvn-test-windows:
runs-on: windows-latest
Expand Down Expand Up @@ -341,7 +341,7 @@ jobs:
- name: bundle install
run: bin/jruby --dev -S bundle install
- name: rake test:jruby
run: bin/jruby --dev -S rake test:jruby TESTOPTS="--no-show-detail-immediately"
run: bin/jruby -S rake test:jruby TESTOPTS="--no-show-detail-immediately"
env:
JRUBY_OPTS: ''
- name: mvn -P test
Expand Down Expand Up @@ -549,7 +549,7 @@ jobs:
- name: bundle install
run: bin/jruby --dev -S bundle install
- name: rake ${{ matrix.target }}
# run: "bin/jruby --dev -S rake ${{ matrix.target }}"
# run: "bin/jruby -S rake ${{ matrix.target }}"
run: "true"

maven-test-openj9-8:
Expand Down Expand Up @@ -617,7 +617,7 @@ jobs:
run: bin/jruby --dev -S bundle install
- name: rake ${{ matrix.target }}
continue-on-error: true
run: "bin/jruby --dev -S rake ${{ matrix.target }}"
run: "bin/jruby -S rake ${{ matrix.target }}"
- run: true

publish-snapshot:
Expand Down

0 comments on commit 3ef5653

Please sign in to comment.