Report errors from get/setsockopt properly

strerror(-1) is not valid, and the error may not be EINVAL.
headius · Oct 8, 2024 · a84bc99 · a84bc99
1 parent 4765ec9
commit a84bc99
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/core/src/main/java/org/jruby/ext/socket/RubyBasicSocket.java b/core/src/main/java/org/jruby/ext/socket/RubyBasicSocket.java
@@ -460,7 +460,7 @@ public IRubyObject getsockopt(ThreadContext context, IRubyObject _level, IRubyOb
                             int ret = SOCKOPT.getsockopt(fd.realFileno, intLevel, intOpt, buf, len);
 
                             if (ret != 0) {
-                                throw runtime.newErrnoEINVALError(SOCKOPT.strerror(ret));
+                                throw runtime.newErrnoFromLastPOSIXErrno();
                             }
                             flipBuffer(buf);
                             ByteList bytes = new ByteList(buf.array(), buf.position(), len.getValue());
@@ -535,7 +535,7 @@ public IRubyObject setsockopt(ThreadContext context, IRubyObject _level, IRubyOb
                             int ret = SOCKOPT.setsockopt(fd.realFileno, intLevel, intOpt, buf, buf.remaining());
 
                             if (ret != 0) {
-                                throw runtime.newErrnoEINVALError(SOCKOPT.strerror(ret));
+                                throw runtime.newErrnoFromLastPOSIXErrno();
                             }
                         }