Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gazetteer cleanup listener #26

Merged
merged 2 commits into from
Mar 2, 2017

Conversation

hkkenneth
Copy link

For #25

@hkkenneth hkkenneth requested a review from mbelousov February 28, 2017 16:35
@mbelousov
Copy link

@hkkenneth, great! Well done! Just thinking, do we need to have something similar to clean output directory before job execution (to remove outputs from previous run)? @healtex/deid

@hkkenneth
Copy link
Author

hkkenneth commented Feb 28, 2017

It can be easily done with a beforeJob() method with an almost identical implementation - do we have any use cases which we may want to keep the files from the previous run?

@hkkenneth
Copy link
Author

On a different note, I think in the future, we could have a configuration to let advanced users keep the gazetteer files after the job: to inspect them, or to use the files to customize their own gazetteers?

@mbelousov
Copy link

@hkkenneth For the first version (consider the desktop application) we could just use name of the input folder and then create corresponding folders: {name}-gazetteers (for step1) and {name}-results (for step2) in that case we will be able to run multiple instances of app (e.g. processing two datasets at the same time).
Agree that it might be a good idea to keep gazetteers, so we can a corresponding option to our workflow and in the desktop app we could have a checkbox.

@hkkenneth
Copy link
Author

What's {name} here? But can't users already achieve the same effect with separate workspace?

@mbelousov
Copy link

@hkkenneth , yep, workspace sounds like a better option.

@mbelousov mbelousov merged commit 1695ed6 into feature/ner-integration Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants