feat: pretty search engine names #189
Closed
+39
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
k4lizen
commented
Jan 26, 2024
•
k4lizen
commented
- added pretty names array
- using pretty names in climode search results output
- where else should these be used? engines.Info?
|
This can be used when returning the JSON results via API, so that pretty names get rendered on the frontend. |
6 tasks
| } | ||
| } | ||
|
|
||
| func init() { |
There was a problem hiding this comment.
This is a runtime error, we must check for it before building our images otherwise it could result in broken version being released. I managed to do this in my PR that tries to add pretty names.
|
This should be closed in favor of #257 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.