Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(search,bucket,sedefaults): better project structure #203

Merged
merged 13 commits into from
Feb 9, 2024

Conversation

aleksasiriski
Copy link
Member

@aleksasiriski aleksasiriski commented Feb 8, 2024

Must be merged after #187

  • Moved every package used for searching into a new folder called "search" - Fixed imports EVERYWHERE and searcher as well
  • Bucket separated code into files
  • Moved Result, RetrievedResult and RetrievedRank into result package
  • Moved search package functions to utils.go
  • Moved concurrency into runEngines and switched from conc to stdlib
  • Made *relay be returned by runEngines

@aleksasiriski aleksasiriski changed the base branch from main to rot-proxies February 8, 2024 13:20
@aleksasiriski aleksasiriski requested a review from k4lizen February 8, 2024 13:21
This was referenced Feb 8, 2024
k4lizen
k4lizen previously approved these changes Feb 8, 2024
Base automatically changed from rot-proxies to main February 9, 2024 18:52
@aleksasiriski aleksasiriski dismissed k4lizen’s stale review February 9, 2024 18:52

The base branch was changed.

@aleksasiriski aleksasiriski merged commit 4228794 into main Feb 9, 2024
5 of 6 checks passed
@aleksasiriski aleksasiriski deleted the refactor-search branch February 9, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants