feat!: remove categories from config and instead pass them as base64 encoded json param #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…encoded json param
|
Huh I see you're passing the category as a parameter, I didn't realize that was part of the idea |
|
Yeah okay this makes sense, there is no loss of information like I was worried about in #443 (comment) |
Yeah I ran into the problem that you mentioned there and came up with this solution, but as I realized it would require a lot of params to get it passed from frontend decided to use base64 instead. Now we need to reimplement the categories on frontend and after that we can make UI for users to make custom ones that can be saved in their cookie. |
…ing TRC, now timesreturnedscoremul)
matijakljajic
previously approved these changes
Nov 15, 2024
|
Approved, waiting on frontend for it to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of BREAKING CHANGES
This PR implements categories (engines to use and their ranking) as an base64 encoded JSON parameter. This means that we do not have the need for predefined categories here (this will be moved to frontend to keep the current ones as they are).
This is the first step towards a distributed network model, allowing faster innovation with less updates for agents (as they're the main self-hosted component) while also allowing us to implement client-side made custom categories (with personal ranking).
Introduction of search types:
Web (before "general") is now separated from image searching.
Old route -> New route:
/healthz->/healthz(same)/versionz->/versionz(same)/search->/search/web(requires newcategoryparam)/search(category images) ->/search/images(requires newcategoryparam)/suggestions->/search/suggestions(requires newcategoryparam)/exchange->/exchange(same)/currencies->/exchange/currencies/proxy->/imageproxyTODO: