Skip to content

Commit

Permalink
bio: Clean up unused members
Browse files Browse the repository at this point in the history
Signed-off-by: Pedro Falcato <[email protected]>
  • Loading branch information
heatd committed Mar 23, 2024
1 parent b486032 commit 4e5a901
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 10 deletions.
6 changes: 0 additions & 6 deletions kernel/drivers/ata/ata.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -342,12 +342,6 @@ ide_drive *ide_drive_from_blockdev(blockdev *dev)
return (ide_drive *) dev->device_info;
}

// bio_req details:
// device_specific[0] layout: top 32 bits = len, bottom 32 is flags
// only 1 flag is defined: bit 0: bounce buffer valid

#define BIO_REQ_HAS_BOUNCE_BUF (1U << 0)

int ide_ata_bus::device_io_submit(struct request *req)
{
auto drive = ide_drive_from_blockdev(req->r_bdev);
Expand Down
3 changes: 0 additions & 3 deletions kernel/include/onyx/bdev_base_types.h
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,7 @@ struct bio_req
size_t nr_vecs;
size_t curr_vec_index;
struct blockdev *bdev;
struct io_queue *b_queue;
struct list_head list_node;
/* TODO: We need to kill this! */
unsigned long device_specific[4];
void (*b_end_io)(struct bio_req *req);
void *b_private;
struct page_iov b_inline_vec[];
Expand Down
1 change: 0 additions & 1 deletion kernel/kernel/fs/block/request.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ struct request *bio_req_to_request(struct bio_req *bio)
bio_request_init(req);
req->r_bdev = bdev;
req->r_flags = bio->flags;
req->r_queue = bio->b_queue;
req->r_sector = bio->sector_number;
/* Append this request to the head */
request_add_bio_head(req, bio);
Expand Down

0 comments on commit 4e5a901

Please sign in to comment.